Skip to content

OCPBUGS-63601: UPSTREAM: <carry>: Skip CPU resource status for workload-partitioning #2504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2025
Merged

OCPBUGS-63601: UPSTREAM: <carry>: Skip CPU resource status for workload-partitioning #2504

merged 1 commit into from
Oct 28, 2025

Conversation

@sdodson
Copy link
Member

@sdodson sdodson commented Oct 28, 2025

…inned pods

What type of PR is this?

/kind bug

What this PR does / why we need it:

Manual cherry pick of #2490

Which issue(s) this PR is related to:

Fixes https://issues.redhat.com/browse/OCPBUGS-63601

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixed CPU double-counting issue for workload-partitioned pods that caused false "Insufficient cpu"
  scheduling errors when InPlacePodVerticalScaling is enabled.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Oct 28, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 28, 2025

@sdodson: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 28, 2025
@sdodson
Copy link
Member Author

sdodson commented Oct 28, 2025

Just fixing the commit message from #2499 where for some reason I was unable to push to the branch.

@sdodson sdodson changed the title UPSTREAM: <carry>: Skip CPU resource status for workload-pinned pods OCPBUGS-63601: UPSTREAM: <carry>: Skip CPU resource status for workload-partitioning Oct 28, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 28, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 28, 2025

@sdodson: This pull request references Jira Issue OCPBUGS-63601, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-62270 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-62270 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
  • bug has dependents

Requesting review from QA contact:
/cc @lyman9966

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

…inned pods

What type of PR is this?

/kind bug

What this PR does / why we need it:

Manual cherry pick of #2490

Which issue(s) this PR is related to:

Fixes https://issues.redhat.com/browse/OCPBUGS-63601

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixed CPU double-counting issue for workload-partitioned pods that caused false "Insufficient cpu"
 scheduling errors when InPlacePodVerticalScaling is enabled.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sdodson sdodson added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Oct 28, 2025
@sdodson
Copy link
Member Author

sdodson commented Oct 28, 2025

/verified by @harche

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 28, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 28, 2025

@sdodson: This PR has been marked as verified by @harche.

In response to this:

/verified by @harche

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Oct 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson
Copy link
Member Author

sdodson commented Oct 28, 2025

/override ci/prow/e2e-gcp ci/prow/e2e-aws-crun-wasm ci/prow/e2e-aws-ovn-cgroupsv2 ci/prow/e2e-aws-ovn-crun ci/prow/e2e-metal-ipi-ovn-ipv6 ci/prow/e2e-aws-ovn-serial

@sdodson
Copy link
Member Author

sdodson commented Oct 28, 2025

/skip

@openshift-ci
Copy link

openshift-ci bot commented Oct 28, 2025

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws-crun-wasm, ci/prow/e2e-aws-ovn-cgroupsv2, ci/prow/e2e-aws-ovn-crun, ci/prow/e2e-aws-ovn-serial, ci/prow/e2e-gcp, ci/prow/e2e-metal-ipi-ovn-ipv6

In response to this:

/override ci/prow/e2e-gcp ci/prow/e2e-aws-crun-wasm ci/prow/e2e-aws-ovn-cgroupsv2 ci/prow/e2e-aws-ovn-crun ci/prow/e2e-metal-ipi-ovn-ipv6 ci/prow/e2e-aws-ovn-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sdodson
Copy link
Member Author

sdodson commented Oct 28, 2025

/override ci/prow/k8s-e2e-gcp-ovn ci/prow/k8s-e2e-gcp-serial ci/prow/e2e-aws-ovn-fips ci/prow/e2e-aws-ovn-runc ci/prow/k8s-e2e-conformance-aws

@openshift-ci
Copy link

openshift-ci bot commented Oct 28, 2025

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-aws-ovn-runc, ci/prow/k8s-e2e-conformance-aws, ci/prow/k8s-e2e-gcp-ovn, ci/prow/k8s-e2e-gcp-serial

In response to this:

/override ci/prow/k8s-e2e-gcp-ovn ci/prow/k8s-e2e-gcp-serial ci/prow/e2e-aws-ovn-fips ci/prow/e2e-aws-ovn-runc ci/prow/k8s-e2e-conformance-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sdodson sdodson merged commit debdebd into openshift:release-4.20 Oct 28, 2025
20 of 22 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 28, 2025

@sdodson: Jira Issue Verification Checks: Jira Issue OCPBUGS-63601
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-63601 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

…inned pods

What type of PR is this?

/kind bug

What this PR does / why we need it:

Manual cherry pick of #2490

Which issue(s) this PR is related to:

Fixes https://issues.redhat.com/browse/OCPBUGS-63601

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixed CPU double-counting issue for workload-partitioned pods that caused false "Insufficient cpu"
 scheduling errors when InPlacePodVerticalScaling is enabled.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 28, 2025

/retest-required

Remaining retests: 0 against base HEAD debdebd and 2 for PR HEAD 87e4cfb in total

@openshift-merge-robot
Copy link

openshift-merge-robot commented Oct 29, 2025

Fix included in accepted release 4.20.0-0.nightly-2025-10-29-051631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lyman9966 lyman9966 Awaiting requested review from lyman9966

@mrunalp mrunalp Awaiting requested review from mrunalp

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@kasturinarra kasturinarra

@zhouying7780 zhouying7780

@xingxingxia xingxingxia

@lyman9966 lyman9966

@duanwei33 duanwei33

@wangke19 wangke19

@gangwgr gangwgr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.